[Webkit-unassigned] [Bug 70501] [Microdata] itemtype attribute should be space-separated list to allow multiple types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70501





--- Comment #3 from Arko Saha <nghq36 at motorola.com>  2011-10-25 01:13:27 PST ---
(In reply to comment #2)
> (From update of attachment 111776 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111776&action=review
> 

> > LayoutTests/fast/dom/MicroData/006.html:11
> > -<div itemscope itemtype="http://example.com/foo"></div>
> > -<div itemscope itemtype="http://example.com/bar">
> > -<div itemscope itemtype="data:text/plain"></div>
> > +<div itemscope itemtype="http://example.com/foo http://example.com/bar"></div>
> > +<div itemscope itemtype="http://example.com/bar http://example.com/foo">
> 
> Why the change?

Accroding to the latest spec getItems() should return all the elements that are each top-level microdata items whose types include "all the types specified" in the method's argument.
Earlier the spec specified that getItems() should return all the elements that are each top-level microdata items whose types include "any one of the types specified" in the method's argument.

So if we do not modify the below test-case,

-<div itemscope itemtype="http://example.com/foo"></div>
-<div itemscope itemtype="http://example.com/bar">
+<div itemscope itemtype="http://example.com/foo http://example.com/bar"></div>
+<div itemscope itemtype="http://example.com/bar http://example.com/foo">

document.getItems(' http://example.com/foo http://example.com/bar ').length == 2 will always be false. Hence I made this changes.
And I have modified this test-case more perfect in my new patch.

> 
> > LayoutTests/fast/dom/MicroData/itemtype-add-remove-tokens.html:35
> > +debug("<br>itemType.remove must not make any changes if a non-existing token is removed.");
> 
> "non-existing token is removed" sounds odd. How about "remove is called for a token that doesn't exist"?
Done!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.