[Webkit-unassigned] [Bug 70501] [Microdata] itemtype attribute should be space-separated list to allow multiple types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 24 14:51:36 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=70501





--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-10-24 14:51:35 PST ---
(From update of attachment 111776)
View in context: https://bugs.webkit.org/attachment.cgi?id=111776&action=review

> LayoutTests/fast/dom/MicroData/006-expected.txt:5
>  PASS document.getItems(' http://example.com/foo http://example.com/bar ').length == 2 is true
> -PASS document.getItems(' http://example.com/foo data:text/plain ').length == 2 is true
> -PASS document.getItems(' http://example.com/foo data:text/plain http://example.com/foo').length == 2 is true
> +PASS document.getItems('  http://example.com/foo  http://example.com/bar  http://example.com/foo').length == 2 is true

Why the change?

> LayoutTests/fast/dom/MicroData/006.html:11
> -<div itemscope itemtype="http://example.com/foo"></div>
> -<div itemscope itemtype="http://example.com/bar">
> -<div itemscope itemtype="data:text/plain"></div>
> +<div itemscope itemtype="http://example.com/foo http://example.com/bar"></div>
> +<div itemscope itemtype="http://example.com/bar http://example.com/foo">

Ditto.

> LayoutTests/fast/dom/MicroData/006.html:16
> -shouldBeTrue("document.getItems(' http://example.com/foo  data:text/plain  ').length == 2");
> -shouldBeTrue("document.getItems('  http://example.com/foo  data:text/plain  http://example.com/foo').length == 2");
> +shouldBeTrue("document.getItems('  http://example.com/foo  http://example.com/bar  http://example.com/foo').length == 2");

Ditto.

> LayoutTests/fast/dom/MicroData/itemtype-add-remove-tokens.html:35
> +debug("<br>itemType.remove must not make any changes if a non-existing token is removed.");

"non-existing token is removed" sounds odd. How about "remove is called for a token that doesn't exist"?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list