[Webkit-unassigned] [Bug 69343] [GTK] Initial implementation of back forward list for WebKit2 GTK+ API

Mon Oct 24 01:00:14 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=69343

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111959|review?                     |review+
               Flag|                            |

--- Comment #21 from Martin Robinson <mrobinson at webkit.org>  2011-10-24 01:00:14 PST ---
(From update of attachment 111959)
View in context: https://bugs.webkit.org/attachment.cgi?id=111959&action=review

Okay! We should later use a similar helper to the Mac port for dealing with the empty string -> null return. I think that would cut down on the code and codify this way of writing the API.

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp:104
> + * Returns: the URI of @back_forward_list_item or %NULL.

Do you mind appending "when the URI is empty" here?

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp:123
> + * Returns: the page title of @back_forward_list_item or %NULL.

...and "when the title is empty" here?

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp:144
> + * Returns: the original URI of @back_forward_list_item or %NULL.

...and "when the URI is empty" here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.