[Webkit-unassigned] [Bug 69343] [GTK] Initial implementation of back forward list for WebKit2 GTK+ API
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 21 06:34:40 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=69343
Carlos Garcia Campos <cgarcia at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #111759|0 |1
is obsolete| |
Attachment #111759|review? |
Flag| |
Attachment #111959| |review?
Flag| |
--- Comment #20 from Carlos Garcia Campos <cgarcia at igalia.com> 2011-10-21 06:34:40 PST ---
Created an attachment (id=111959)
--> (https://bugs.webkit.org/attachment.cgi?id=111959&action=review)
New patch
Another update addressing all review comments, except returning empty strings, I still think we should return NULL instead, for the following reasons:
- It's a common pattern in GNOME platform, so we should be consistent with our platform
- For this reason, this is what our users expect, look at this ephy commit for example:
http://git.gnome.org/browse/epiphany/commit/?id=9ea9e684b4cb5563d5b395a93b923771b0f6bffc
Even though wk1 returns empty strings, both new and old code in that patch checks for NULL, not to for ""
- Mac API returns NULL too (well, nil): see http://trac.webkit.org/browser/trunk/Source/WebKit/mac/History/WebHistoryItem.mm#L167
- It avoids unnecessary allocation and string comparison
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list