[Webkit-unassigned] [Bug 70110] [Qt] fast/events/media-focus-in-standalone-media-document.html fails

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 19 10:35:30 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=70110





--- Comment #3 from Deepak Sherveghar <bpwv64 at motorola.com>  2011-10-19 10:35:30 PST ---
(In reply to comment #2)

> Are the ports in WebKit1 checking for this as well? I took a quick look at WebKit2 and unless I'm missing something, the common implementation of WebPageProxy::canShowMIMEType doesn't check for this.

Atleast the GTK port does for WebKit1.
Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp
bool FrameLoaderClient::canShowMIMEType(const String& type) const
{
    return (MIMETypeRegistry::isSupportedImageMIMEType(type)
            || MIMETypeRegistry::isSupportedNonImageMIMEType(type)
            || MIMETypeRegistry::isSupportedMediaMIMEType(type)
            || PluginDatabase::installedPlugins()->isMIMETypeRegistered(type));
}


> > With the above two fixes, test case runs fine. Both the above two points are necessary to fix this failing test case in QT.
> > 
> > Let me know your thoughts on this.
> > If it seems reasonable enough will upload the patch.
> 
> Well, if you say the test works with the above fixes then I guess we can say that standalone media element is supported by Qt, right? Maybe it would be a good idea to take a look at the patch and once it's reviewed and landed I (or even you, if you are up to) can investigate if it fits on our WebKit2 port as well.

Yes, with the above fixes QT does render standalone media elements as well as test case runs as expected.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list