[Webkit-unassigned] [Bug 70110] [Qt] fast/events/media-focus-in-standalone-media-document.html fails

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 19 09:27:34 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=70110





--- Comment #2 from Jesus Sanchez-Palencia <jesus at webkit.org>  2011-10-19 09:27:32 PST ---
(In reply to comment #1)
Thanks for taking a look at this!

> if (MIMETypeRegistry::isSupportedMediaMIMEType(type))
>         return true;

Are the ports in WebKit1 checking for this as well? I took a quick look at WebKit2 and unless I'm missing something, the common implementation of WebPageProxy::canShowMIMEType doesn't check for this.

> I am not not sure as to why standalone media element is not supported as of yet in QT. Is it because of some design decision that may have happened earlier or a feature QT port doesn't wish to support??

I'm not sure whether it is supported or not, sorry. 


> 
> I think we should publish the media mimetypes in the extensionmap. Something like 
> ie: in MIMETypeRegistryQT.cpp
> 
> static const ExtensionMap extensionMap[] = {
> ... 
> { "mp4", "video/mp4" },
> { "m4v", "video/mp4" },
> { "m4a", "audio/x-m4a"},
> { "mp3", "audio/mp3"},
> { "ogv", "video/ogg"},
> { "oga", "audio/ogg"},
> { "webm", "video/webm},
> { "webm", "audio/webm},
> { "wav", "audio/wav"},
> ..
> };

It seems something that would be good to have. But maybe Alexis will have a better opinion on this.


> With the above two fixes, test case runs fine. Both the above two points are necessary to fix this failing test case in QT.
> 
> Let me know your thoughts on this.
> If it seems reasonable enough will upload the patch.

Well, if you say the test works with the above fixes then I guess we can say that standalone media element is supported by Qt, right? Maybe it would be a good idea to take a look at the patch and once it's reviewed and landed I (or even you, if you are up to) can investigate if it fits on our WebKit2 port as well.

Thanks again!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list