[Webkit-unassigned] [Bug 70397] Rename AllowAllocation to a better name

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 19 00:23:35 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=70397





--- Comment #4 from Kentaro Hara <haraken at chromium.org>  2011-10-19 00:23:34 PST ---
(In reply to comment #2)
> (From update of attachment 111563 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111563&action=review
> 
> > Source/WebCore/bindings/v8/V8Binding.h:211
> > -        AllowAllocation allow;
> > +        ConstructorMode allow;
> 
> Maybe rename "allow" to something else?

Renamed to "constructorMode", and committed. Thanks.

By the way, I am planning to add the ConstructorMode check to all existing custom ~25 constructors, but does that make sense?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list