[Webkit-unassigned] [Bug 70140] Flush denormals to zero on Windows.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 18 10:33:07 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=70140


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111451|review?                     |review-
               Flag|                            |




--- Comment #19 from Kenneth Russell <kbr at google.com>  2011-10-18 10:33:07 PST ---
(From update of attachment 111451)
View in context: https://bugs.webkit.org/attachment.cgi?id=111451&action=review

>> Source/WebCore/platform/audio/DenormalDisabler.h:28
>> +#if OS(WINDOWS) && COMPILER(MSVC) && (_M_IX86_FP == 0)
> 
> Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]

To satisfy the style queue the last expression should be written as (!_M_IX86_FP). Here and below.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list