[Webkit-unassigned] [Bug 70140] Flush denormals to zero on Windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70140





--- Comment #20 from Chris Rogers <crogers at google.com>  2011-10-18 10:41:52 PST ---
(From update of attachment 111451)
View in context: https://bugs.webkit.org/attachment.cgi?id=111451&action=review

>>> Source/WebCore/platform/audio/DenormalDisabler.h:28
>>> +#if OS(WINDOWS) && COMPILER(MSVC) && (_M_IX86_FP == 0)
>> 
>> Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
> 
> To satisfy the style queue the last expression should be written as (!_M_IX86_FP). Here and below.

Actually, just to make things simpler and more readable I would recommend removing the #if

It's true that it'll include an unneeded include file on some platforms, but it seems worth the cost due to readability.  What do you think Ken?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.