[Webkit-unassigned] [Bug 70140] Flush denormals to zero on Windows.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 17 14:26:55 PDT 2011


--- Comment #12 from Chris Rogers <crogers at google.com>  2011-10-17 14:26:55 PST ---
(From update of attachment 111105)
View in context: https://bugs.webkit.org/attachment.cgi?id=111105&action=review

Please look at style errors and address for next patch.

>> Source/WebCore/platform/audio/DenormalDisabler.h:28
>> +#if OS(WIN) && defined(_MSC_VER) && (_M_IX86_FP == 0)
> Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]

Is there any reason we need to include a Windows specific header file here?  It doesn't seem like we have to.  I'd recommend:

#include <wtf/MathExtras.h>

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list