[Webkit-unassigned] [Bug 66878] HTMLAudioElement can be garbage collected while it playing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66878





--- Comment #44 from Eugene Nalimov <enal at google.com>  2011-10-17 13:14:23 PST ---
>I agree with Eric that the V8 bindings fix and the audio element fix should be separated.

Ok, will separate. Hope I'll be able to check in audio element fix without test case -- I was told it is no-no...

>This should be private, not public.

The moment you make type "officially" active -- i.e. it does not just inherit from ActiveDOMObject, but code generator knows about it -- hasPendingActivity() should be public, otherwise some generated code would not compile: http://queues.webkit.org/results/9969312. I initially had protected/private, exactly as you suggested...

>This is wrong. We never have to repeat the EventTarget interface like this in a Node subclass. If this was necessary we’d have it tons of other classes too.

I tried to limit the change to HTMLAudioElement node, without touching Node class -- reviewer wrote "... event listener thing is subtle and needs to be done carefully."... My initial attempt included Node fix, and I still think it is right one.

Will submit audio fix only, but we really need both parts of the fix, because events are being lost...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.