[Webkit-unassigned] [Bug 66878] HTMLAudioElement can be garbage collected while it playing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66878


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110845|review?                     |review-
               Flag|                            |




--- Comment #43 from Darin Adler <darin at apple.com>  2011-10-17 12:49:57 PST ---
(From update of attachment 110845)
View in context: https://bugs.webkit.org/attachment.cgi?id=110845&action=review

I agree with Eric that the V8 bindings fix and the audio element fix should be separated.

> Source/WebCore/html/HTMLAudioElement.h:43
> +    virtual bool hasPendingActivity() const { return isPlaying() || HTMLMediaElement::hasPendingActivity(); }

This should be private, not public.

> Source/WebCore/html/HTMLAudioElement.idl:29
> +        EventTarget,

This is a bad idea.

> Source/WebCore/html/HTMLAudioElement.idl:40
> +        // EventTarget interface                           
> +        void addEventListener(in DOMString type,
> +                              in EventListener listener,
> +                              in [Optional] boolean useCapture);
> +        void removeEventListener(in DOMString type,
> +                                 in EventListener listener,
> +                                 in [Optional] boolean useCapture);
> +        boolean dispatchEvent(in Event event)
> +            raises(EventException);    

This is wrong. We never have to repeat the EventTarget interface like this in a Node subclass. If this was necessary we’d have it tons of other classes too.

> Source/WebCore/html/HTMLMediaElement.h:61
> +class HTMLMediaElement : public HTMLElement, public MediaPlayerClient, private MediaCanStartListener, public ActiveDOMObject {

This should stay private.

> Source/WebCore/html/HTMLMediaElement.h:208
> +    virtual bool hasPendingActivity() const;

This should be protected, not public.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.