[Webkit-unassigned] [Bug 64865] Switch isQuirkValue() virtual function to inline one.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64865


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111125|review?                     |review+
               Flag|                            |




--- Comment #24 from Darin Adler <darin at apple.com>  2011-10-15 13:17:32 PST ---
(From update of attachment 111125)
View in context: https://bugs.webkit.org/attachment.cgi?id=111125&action=review

Not setting commit-queue+ because of David’s comment, and my related one.

>> Source/WebCore/css/CSSQuirkPrimitiveValue.h:-31
>> -// inside a table cell.
> 
> I think this comment should have followed CSSQuirkPrimitiveValue::create() when it became CSSPrimitiveValue::createQuirk().

I agree. I also would suggest naming the new function CSSPrimitiveValue::createAllowingMarginQuirk().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.