[Webkit-unassigned] [Bug 64865] Switch isQuirkValue() virtual function to inline one.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 14 23:27:49 PDT 2011


--- Comment #23 from David Barr <davidbarr at chromium.org>  2011-10-14 23:27:49 PST ---
(From update of attachment 111125)
View in context: https://bugs.webkit.org/attachment.cgi?id=111125&action=review

Sorry for the noise, I noticed some nits just after uploading the patch.

> Source/WebCore/WebCore.gypi:-2383
> -            'css/CSSQuirkPrimitiveValue.h',

As a developer new to WebKit, I'm not familiar with the process of propagating this change. FWIW, it doesn't appear to break the build.

> Source/WebCore/css/CSSQuirkPrimitiveValue.h:-31
> -// This value is used to handle quirky margins in reflow roots (body, td, and th) like WinIE.
> -// The basic idea is that a stylesheet can use the value __qem (for quirky em) instead of em.
> -// When the quirky value is used, if you're in quirks mode, the margin will collapse away
> -// inside a table cell.

I think this comment should have followed CSSQuirkPrimitiveValue::create() when it became CSSPrimitiveValue::createQuirk().

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list