[Webkit-unassigned] [Bug 64865] Switch isQuirkValue() virtual function to inline one.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64865


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110959|review?                     |review+
               Flag|                            |




--- Comment #19 from Darin Adler <darin at apple.com>  2011-10-14 08:44:59 PST ---
(From update of attachment 110959)
This idea is fine, but there is no reason to keep an entire class, CSSQuirkPrimitiveValue, any more given that the class has no contents. Instead we just need a new create function in CSSPrimitiveValue that creates a quirk value.

Doing it that way will remove an entire unnecessary vtable, make the code cleaner and easier to understand, and also remove the need to add new protected members.

I’m going to say review+ but I’d much prefer this be redone to eliminate the class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.