[Webkit-unassigned] [Bug 64865] Switch isQuirkValue() virtual function to inline one.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 14 11:05:00 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64865





--- Comment #20 from Antti Koivisto <koivisto at iki.fi>  2011-10-14 11:05:00 PST ---
(In reply to comment #19)
> Doing it that way will remove an entire unnecessary vtable, make the code cleaner and easier to understand, and also remove the need to add new protected members.

Unfortunately it will take much more than that to remove vtable from CSSValues. CSSPrimitiveValue is not the base class.

> I’m going to say review+ but I’d much prefer this be redone to eliminate the class.

Yeah, definitely. I didn't notice that there was nothing else there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list