[Webkit-unassigned] [Bug 61344] --webkit-visual-word does not work in multi-line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61344





--- Comment #38 from Ryosuke Niwa <rniwa at webkit.org>  2011-10-12 15:37:08 PST ---
(In reply to comment #36)
> (From update of attachment 110748 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110748&action=review
> 
> >> Source/WebCore/editing/visible_units.cpp:606
> >> +    }
> > 
> > Why do we need this struct? Can't we just pass arguments around?
> 
> yes you are right that we do not need this struct. instead, we can just pass arguments around. then, instead of a struct, we will need to pass 4 arguments around. Also, the |offset| and |root| are only needed if the |rule| is CanNotCrossEditingBoundary.

Could you elaborate on why we need those 4 arguments?

> >> Source/WebCore/editing/visible_units.cpp:629
> >> +    RootInlineBox*& rootInlineBox, Position& candidatePos) {
> > 
> > Maybe this needs to moved to RenderedPosition.
> 
> what is the rule-of-thumb here?

RenderedPosition is meant to provide abstraction around renderers and inline boxes in editing code. If the code touches inline boxes and/or talks on render tree, then it's a strong indication that it should belong in RenderedPosition.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.