[Webkit-unassigned] [Bug 68462] Update PeerConnection to use WebCore platform interfaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68462


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110603|review?                     |review+
               Flag|                            |




--- Comment #9 from Adam Barth <abarth at webkit.org>  2011-10-12 09:42:42 PST ---
(From update of attachment 110603)
View in context: https://bugs.webkit.org/attachment.cgi?id=110603&action=review

> Source/WebCore/p2p/PeerConnection.cpp:39
> -PassRefPtr<PeerConnection> PeerConnection::create(MediaStreamFrameController* frameController, int id, const String& configuration, PassRefPtr<SignalingCallback> signalingCallback)
> +PassRefPtr<PeerConnection> PeerConnection::create(const String& serverConfiguration, PassRefPtr<SignalingCallback> signalingCallback, ScriptExecutionContext* context)

I think the patch to move this to the front has landed.  We need to check that this compiles when landing.

> Source/WebCore/p2p/PeerConnection.cpp:169
> +    MediaStreamDescriptor* streamDescriptor = 0;
> +    size_t i = m_pendingAddStreams.find(streamDescriptor);
> +    if (i != notFound) {
> +        m_pendingAddStreams.remove(i);
>          return;
> +    }
> +
> +    m_pendingRemoveStreams.append(streamDescriptor);
> +    if (m_iceStarted)
> +        ensureStreamChangeScheduled();

This code appears duplicated.  Maybe break out into a helper function?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.