[Webkit-unassigned] [Bug 68462] Update PeerConnection to use WebCore platform interfaces

Tue Oct 11 16:42:10 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=68462

Adam Bergkvist <adam.bergkvist at ericsson.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110529|0                           |1
        is obsolete|                            |
 Attachment #110603|                            |review?
               Flag|                            |

--- Comment #8 from Adam Bergkvist <adam.bergkvist at ericsson.com>  2011-10-11 16:42:10 PST ---
Created an attachment (id=110603)
 --> (https://bugs.webkit.org/attachment.cgi?id=110603&action=review)
Patch 5

(In reply to comment #6)

> I can understand the aesthetic issue, but we use these various types to communicate different ownership patterns.  We use this type (somewhat rarely) to mean that it's essential that the caller explicitly hold a reference to the object (e.g., on the stack) because this function could trigger a cascade of dereferences.
> 
> In the end, it's just a style thing and not a big deal, but it's slightly more consistent with the rest of WebKit to just take a raw pointer here.

Let's go with raw pointers for consistency.

> > The initial readyState NEW is not handled in the switch. An alternative would be to add case NEW and move the ASSERT there.
> 
> Please do.  That's part of why we like that style.  :)

Fixed.

I'll upload the next patch which updates MediaStream/LocalMediaStream in http://webkit.org/b/68464

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.