[Webkit-unassigned] [Bug 69838] Resolve regular and visited link style in a single pass

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 00:50:03 PDT 2011


--- Comment #3 from Antti Koivisto <koivisto at iki.fi>  2011-10-12 00:50:02 PST ---
(In reply to comment #2)
> (From update of attachment 110545 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110545&action=review
> I read over this and did not spot any mistakes.
> > Source/WebCore/css/CSSStyleSelector.cpp:210
> > -    unsigned m_position : 28;
> > +    unsigned m_position : 26;
> How many bits do we really need for this? Can it be even less than 26? How do we handle overflow?

We need enough bits to hold the total count of all (author) style rules that may apply to a document. In practice we can do with way less bits than this still. Overflow is not handled. It is not particularly dangerous (just messes up the style resolution) and we are going to be in trouble with millions of rules well before that anyway.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list