[Webkit-unassigned] [Bug 69838] Resolve regular and visited link style in a single pass

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 11 17:33:48 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69838


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110545|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2011-10-11 17:33:47 PST ---
(From update of attachment 110545)
View in context: https://bugs.webkit.org/attachment.cgi?id=110545&action=review

I read over this and did not spot any mistakes.

> Source/WebCore/css/CSSStyleSelector.cpp:210
> -    unsigned m_position : 28;
> +    unsigned m_position : 26;

How many bits do we really need for this? Can it be even less than 26? How do we handle overflow?

> Source/WebCore/css/CSSStyleSelector.cpp:1292
> +        // pseudo element styles will continue to work for pseudo elements inside :visited
> +        // links.

I’d put that last word on the previous line.

> Source/WebCore/css/SelectorChecker.h:90
> +    enum LinkMatchMask {  MatchLink = 1, MatchVisited = 2, MatchAll = MatchLink | MatchVisited };

Extra space here before MatchLink.

> Source/WebCore/rendering/style/RenderStyle.cpp:260
> +    ASSERT(pseudo->styleType() > NOPSEUDO);

Might be worth a “why this is a good assertion” comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list