[Webkit-unassigned] [Bug 69753] [GTK] Initial UI client implementation for WebKit2 GTK +API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 11 00:44:13 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69753





--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-10-11 00:44:13 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #4)
> > > (From update of attachment 110349 [details] [details] [details])
> 
> > I think web view is actually the ui client, that's why I haven't used a separate client for this. I you want the ui client separated from the page, we should probably add a page class like Gustavo suggested. 
> 
> The WebKitWebView is the actual widget, but the UIClient controls everything surrounding the WebView. I think it makes sense to split them into two things.  For instance, setMenuBarIsVisible has no relation to the WebView widget at all. There are some delegates that I associate with the widget itself such as focus and unfocus -- maybe we can consider having the UIClient just fire signals on the WebView.  What do you think?

If we are talking about internal code separation, it's fine with me, what I don't see is a WebKitWebUIClient object like the loader client or the policy client.

> Do you mind expanding a bit on how the existence of a page client would change things?

The web view would be the UI client, while the page object would do the other things the view currently does.

> > 
> > > I believe that the ::ready signal should be called ::show to match the underlying API.
> > 
> > I find "show" very confusing.
> 
> Do you mind elaborating a bit on this?

Show makes me think you have to show the view or something, while you don't have to. The first time I saw it I thought it was called everytime you have to show the view for some reason. But it's called only once, to notify that the new view is *ready*.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list