[Webkit-unassigned] [Bug 69412] REGRESSIoN (r95399): Web process hangs when opening documents on Google Docs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69412





--- Comment #12 from Filip Pizlo <fpizlo at apple.com>  2011-10-10 13:49:49 PST ---
> >> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:688
> >> +        if (false) return false;
> > 
> > More than one command on the same line in if  [whitespace/parens] [4]
> 
> This seems unlikely to be correct…

Ahhhh, that's embarrassing.

> > Source/JavaScriptCore/jit/JIT.cpp:540
> > -#if ENABLE(DFG_JIT)
> > -    if (m_canBeOptimized)
> > -        m_startOfCode = label();
> > +#if ENABLE(DFG_JIT) || ENABLE(JIT_VERBOSE)
> > +    m_startOfCode = label();
> 
> Shouldn't this be if (m_canBeOptimized || ENABLE(JIT_VERBOSE)) ?

The alternative scares me, and label() is free.  I'm setting it whenever the field exists because otherwise you'd have something like:

#if ENABLE(DFG_JIT) || ENABLE(JIT_VERBOSE)
#if ENABLE(VALUE_PROFILER)
     if (m_canBeOptimized || ENABLE(JIT_VERBOSE))
#else
     if (true)
#endif
         m_startOfCode = label();
#endif

Or something like that.  Problem is that m_canBeOptimized is a field that doesn't always exist, and m_startOfCode is also a field that doesn't always exist.  I'd rather keep it simple.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.