[Webkit-unassigned] [Bug 69412] REGRESSIoN (r95399): Web process hangs when opening documents on Google Docs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69412


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110392|review?                     |review-
               Flag|                            |




--- Comment #11 from Oliver Hunt <oliver at apple.com>  2011-10-10 13:43:49 PST ---
(From update of attachment 110392)
View in context: https://bugs.webkit.org/attachment.cgi?id=110392&action=review

>> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:688
>> +        if (false) return false;
> 
> More than one command on the same line in if  [whitespace/parens] [4]

This seems unlikely to be correct...

>> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:707
>> +        if (false) return false;
> 
> More than one command on the same line in if  [whitespace/parens] [4]

:D

>> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:711
>> +        if (false) return false;
> 
> More than one command on the same line in if  [whitespace/parens] [4]

:D

> Source/JavaScriptCore/jit/JIT.cpp:540
> -#if ENABLE(DFG_JIT)
> -    if (m_canBeOptimized)
> -        m_startOfCode = label();
> +#if ENABLE(DFG_JIT) || ENABLE(JIT_VERBOSE)
> +    m_startOfCode = label();

Shouldn't this be if (m_canBeOptimized || ENABLE(JIT_VERBOSE)) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.