[Webkit-unassigned] [Bug 69605] CSS Counters have wrong values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69605





--- Comment #4 from Darin Adler <darin at apple.com>  2011-10-07 17:19:46 PST ---
(From update of attachment 110234)
View in context: https://bugs.webkit.org/attachment.cgi?id=110234&action=review

> Source/WebCore/rendering/RenderObject.h:169
> +    // This function only returns the renderer of the "after" pseudoElement if it is a child of
> +    // this renderer. If "continuations" exist, the function returns 0 even if the element that
> +    // generated this renderer has an "after" pseudo-element.
>      RenderObject* afterPseudoElementRenderer() const
>      {
>          if (const RenderObjectChildList* children = virtualChildren())
>              return children->afterPseudoElementRenderer(this);
>          return 0;
>      }
> +
> +    // This function goes through continuations if any to retrieve the "after" pseudo-element.
> +    RenderObject* rendererOfAfterPseudoElement();

The comments are good, but to me the names are indistinguishable.

Can we name these so you can tell the difference? Maybe we could include the word “find” or “retrieve” or “continuations” in the second function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.