[Webkit-unassigned] [Bug 69605] CSS Counters have wrong values

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 7 17:21:53 PDT 2011


--- Comment #5 from Darin Adler <darin at apple.com>  2011-10-07 17:21:53 PST ---
(From update of attachment 110234)
View in context: https://bugs.webkit.org/attachment.cgi?id=110234&action=review

> Source/WebCore/rendering/RenderObject.cpp:452
> +RenderObject* RenderObject::rendererOfAfterPseudoElement()
> +{
> +    RenderObject* lastContinuation = this;
> +    while (RenderObject* continuation = lastContinuation->virtualContinuation())
> +        lastContinuation = continuation;
> +    return lastContinuation->afterPseudoElementRenderer();
> +}

This code is unnecessarily inefficient. Only the first call needs to be virtualContinuation. Once we have called it once we can call the non-virtual continuation function.

Does this really need to be a member function? Maybe we should just use a helper function in RenderCounter.cpp and not touch the RenderObject.h/cpp source file at all.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list