[Webkit-unassigned] [Bug 69630] [GStreamer] webkitwebsrc: avoid GST_BOILERPLATE_FULL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 7 08:50:36 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69630





--- Comment #3 from Philippe Normand <pnormand at igalia.com>  2011-10-07 08:50:37 PST ---
(In reply to comment #2)
> Attachment 110150 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> 
> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:136:  More than one command on the same line  [whitespace/newline] [4]
> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:138:  webkit_web_src_class_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:211:  webkit_web_src_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> Total errors found: 3 in 2 files
> 
> 

This is how G_DEFINE_TYPE works, I can't rename those functions I'm afraid.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list