[Webkit-unassigned] [Bug 69522] Missing ifdef for some features in the V8 binding

Thu Oct 6 06:37:57 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=69522

Nayan Kumar K <nayankk at motorola.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nayankk at motorola.com

--- Comment #3 from Nayan Kumar K <nayankk at motorola.com>  2011-10-06 06:37:57 PST ---
Earlier I had submitted similar patch to resolve such compilation issue when some of the macro's are disabled - https://bugs.webkit.org/show_bug.cgi?id=63920. Based on the review comments, I seems like we need to generate these files all the time and have the macro embedded within the generated cpp|h files :(. While submitting the re-factored V8 porting patch, I will try to follow this approach mentioned by Alexey Proskuryakov in the in bug #63920.

BTW, Aren't the changes in V8ScriptProfileNode[Custom].cpp files the part of https://bugs.webkit.org/attachment.cgi?id=102530?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.