[Webkit-unassigned] [Bug 69522] Missing ifdef for some features in the V8 binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69522





--- Comment #4 from Rémi Duraffort <remi.duraffort at st.com>  2011-10-06 06:47:23 PST ---
(In reply to comment #3)
> Based on the review comments, I seems like we need to generate these files all the time and have the macro embedded within the generated cpp|h files :(. While submitting the re-factored V8 porting patch, I will try to follow this approach mentioned by Alexey Proskuryakov in the in bug #63920.
These ifdefs does not comment out generated files but features that might no be enabled.
The files are always present but not the features.
I think that's meaning of the review in #63920: generate every files even if they are not used afterward and ifdef the features inside the files. That's what my page is doing IMHO.


> BTW, Aren't the changes in V8ScriptProfileNode[Custom].cpp files the part of https://bugs.webkit.org/attachment.cgi?id=102530?
Arg, yes they are already part of your initial patch (sorry I haven't checked these ones).
They should be a separate patch for me as that's a generical bug (the feature should be ifdefed).
I will recreate the patch without your part.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.