[Webkit-unassigned] [Bug 69366] Web Inspector: CodeGenerator should not use pointers for out params of RefPtr type.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69366





--- Comment #5 from Pavel Feldman <pfeldman at chromium.org>  2011-10-04 14:06:09 PST ---
(In reply to comment #1)
> It should return PassRefPtr's instead?  PassRefPtr is strictly superior to RefPtr& when possible.

I thought that RefPtr& was the preferred way in case of multiple out parameters. It was allowed in the style:http://trac.webkit.org/changeset/94803 and supported my Darin and Maciej on a recent thread.

> It's fine to use out arguments but it's NOT okay to use raw pointers for that. I'm actually surprised that there's no mentioning of this in WebKit's style guideline.

Although not in the guidelines, references are typically expected to be used, so your original request makes perfect sense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.