[Webkit-unassigned] [Bug 69366] Web Inspector: CodeGenerator should not use pointers for out params of RefPtr type.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69366


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2011-10-04 14:02:19 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > It should return PassRefPtr's instead?  PassRefPtr is strictly superior to RefPtr& when possible.
> 
> This is only for *out* arguments, meaning that callees are supposed to override the values of those variables. We currently use RefPtr<..>* result :(

It's fine to use out arguments but it's NOT okay to use raw pointers for that. I'm actually surprised that there's no mentioning of this in WebKit's style guideline.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.