[Webkit-unassigned] [Bug 69329] [WebKit2][gtk] Fix warnings while generating documentation using gtk-doc.

Tue Oct 4 08:46:40 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=69329

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109621|review?                     |review-
               Flag|                            |

--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-10-04 08:46:40 PST ---
(From update of attachment 109621)
View in context: https://bugs.webkit.org/attachment.cgi?id=109621&action=review

I really, really, really, really appreciate this! Please accept my humble suggestion below.

> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:41
> + * @WEBKIT_NETWORK_ERROR_FAILED: Resource loading failed.
> + * @WEBKIT_NETWORK_ERROR_TRANSPORT: Transport protocol error.
> + * @WEBKIT_NETWORK_ERROR_UNKNOWN_PROTOCOL: Can not honor the request because protocol is not known.
> + * @WEBKIT_NETWORK_ERROR_CANCELLED: Load request is cancelled.
> + * @WEBKIT_NETWORK_ERROR_FILE_DOES_NOT_EXIST: File does not exists error.

I think we should use a consistent phrase for all of these and avoid the use of periods (since they aren't complete sentences):

So:
Generic load failure
Load failure due to transport error
Load failure due to unknown protocol
Load failure due to cancellation
Load failure due to missing file

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.