[Webkit-unassigned] [Bug 69329] [WebKit2][gtk] Fix warnings while generating documentation using gtk-doc.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 4 07:36:58 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69329





--- Comment #4 from Nayan Kumar K <nayankk at motorola.com>  2011-10-04 07:36:58 PST ---
(From update of attachment 109599)
View in context: https://bugs.webkit.org/attachment.cgi?id=109599&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:37

> 
> Protocol breakdown sounds unnecessarily techy, can we do better? =) is this what we get when there's failure resolving DNS, the connection is refused or drops? What's the difference from this to transport error?

:). Changed the description for WEBKIT_NETWORK_ERROR_FAILED to "Resource loading failed" in modified patch.

Please note that, there aren't any documentation for these enums anywhere in source code. WebKit1 lacks the documentation for these enums, mac and other ports doesn't expose them and it is not clear from source code when they get triggered. These documentation are the best I could make by referring Source/WebCore/platform/gtk/ErrorsGtk.cpp and http://doc.qt.nokia.com/4.7-snapshot/qnetworkreply.html

>> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:40
>> + * @WEBKIT_NETWORK_ERROR_CANCELLED: Requested operation is invalid.
> 
> Cancelled = invalid?

Changed it to 'Load request cancelled', as per Source/WebCore/platform/gtk/ErrorsGtk.cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list