[Webkit-unassigned] [Bug 56466] Popup menu can get stuck in closed state when GtkMenu can't grab mouse.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 3 03:13:07 PDT 2011


Wajahat Siddiqui <mdwajahatali.siddiqui at motorola.com> changed:

           What    |Removed                     |Added
                 CC|                            |mdwajahatali.siddiqui at motor
                   |                            |ola.com

--- Comment #5 from Wajahat Siddiqui <mdwajahatali.siddiqui at motorola.com>  2011-10-03 03:13:07 PST ---
(In reply to comment #3)
> (From update of attachment 109276 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109276&action=review
> > Source/WebCore/platform/gtk/PopupMenuGtk.cpp:95
> > +    // GTK can refuse to actually open the menu when mouse grabs fails.
> > +    // Ensure WebCore does not go into some pesky state.
> > +    if (!gtk_widget_get_visible(m_popup->platformMenu()))
> > +        client()->popupDidHide();
> You shold also include this fix in Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp.

Thanks for your comments, 
I need to talk to webcore from UIProcess to do client()->popupDidHide(). 
I see WebProcess calls ShowPopupMenu() in WebPopupMenu::show() and there is no such  m_popupClient available with UIProcess 
to do above task. There could be few ways to do it if i am correct?

1) Send m_popupClient as an argument to ShowPopupMenu()
2) Implement IPC mechanism from WebPopupMenuProxyGtk that will inform webcore if popupmenu is displayed. 
3) Have PopupMenuGtk owned with WebPopupMenuProxyGtk class with this we can access PopupMenuClient

Let me know your suggestions before i start implementing!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list