[Webkit-unassigned] [Bug 73524] upstream BlackBerry porting of KURL/Logging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73524





--- Comment #3 from Mary Wu <mary.wu at torchmobile.com.cn>  2011-11-30 23:49:46 PST ---
(In reply to comment #2)
> (From update of attachment 117346 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117346&action=review
> 
> > Source/WebCore/platform/blackberry/KURLBlackBerry.cpp:33
> > +    return String(path());
> 
> KURL::path() returns a string. Therefore, it's sufficient to do:
> 
> return path();

OK


> > Source/WebCore/platform/blackberry/LoggingBlackBerry.cpp:32
> > +void InitializeLoggingChannelsIfNecessary()
> 
> The name of this function doesn't conform to the WebKit Code Style Guidelines. Function names should be in camel case starting with a lowercase letter.

The function name was defined in header file platform/Logging.h, qt/mac/efl/win/wx/gtk all follows. If we fix this style issue, should we do that in a separate PR with all portings changed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.