[Webkit-unassigned] [Bug 73524] upstream BlackBerry porting of KURL/Logging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73524


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117346|review?                     |review-
               Flag|                            |




--- Comment #2 from Daniel Bates <dbates at webkit.org>  2011-11-30 23:29:17 PST ---
(From update of attachment 117346)
View in context: https://bugs.webkit.org/attachment.cgi?id=117346&action=review

> Source/WebCore/platform/blackberry/KURLBlackBerry.cpp:33
> +    return String(path());

KURL::path() returns a string. Therefore, it's sufficient to do:

return path();

> Source/WebCore/platform/blackberry/LoggingBlackBerry.cpp:32
> +void InitializeLoggingChannelsIfNecessary()

The name of this function doesn't conform to the WebKit Code Style Guidelines. Function names should be in camel case starting with a lowercase letter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.