[Webkit-unassigned] [Bug 73397] [BlackBerry] Upstream BlackBerry porting of pluginView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73397





--- Comment #3 from Charles Wei <charles.wei at torchmobile.com.cn>  2011-11-30 18:41:09 PST ---
(From update of attachment 117128)
View in context: https://bugs.webkit.org/attachment.cgi?id=117128&action=review

>> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1054
>> +bool PluginView::platformGetValueStatic(NPNVariable variable, void* value, NPError* result)
> 
> Maybe a static local function?

This is defined in the cross-platform PluginView.h as a static member function.

>> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1092
>> +        *((void **) value) = (void*)&(((NPSetWindowCallbackStruct*)m_npWindow.ws_info)->zoomFactor);
> 
> can we avoid the c-cast here?

Yes

>> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1103
>> +                void** v = (void**) value;
> 
> ditto

Yes

>> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1120
>> +            BlackBerry::Platform::Graphics::Window *window =
> 
> * position

Yes

>> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1124
>> +                *v = (void*) window->windowGroup();
> 
> ditto (c-cast)

window->windowGroup() returns const char*,   there isn't an easy c++ way to cast that to void*, so I would suggest we keep this.

>> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1144
>> +                *v = (void*) context;
> 
> ditto

Yes

> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1158
> +        void** v = (void**) value;

This can be static_cast

>> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1159
>> +        *v = (void*) m_private->m_pluginUniquePrefix.c_str();
> 
> ditto

No easy C++ cast from const char* to void*,  so I would suggest we keep it here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.