[Webkit-unassigned] [Bug 73397] [BlackBerry] Upstream BlackBerry porting of pluginView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73397





--- Comment #2 from Antonio Gomes <tonikitoo at webkit.org>  2011-11-30 07:24:02 PST ---
(From update of attachment 117128)
View in context: https://bugs.webkit.org/attachment.cgi?id=117128&action=review

> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1054
> +bool PluginView::platformGetValueStatic(NPNVariable variable, void* value, NPError* result)

Maybe a static local function?

> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1092
> +        *((void **) value) = (void*)&(((NPSetWindowCallbackStruct*)m_npWindow.ws_info)->zoomFactor);

can we avoid the c-cast here?

> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1103
> +                void** v = (void**) value;

ditto

> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1120
> +            BlackBerry::Platform::Graphics::Window *window =

* position

> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1124
> +                void** v = (void**) value;
> +                *v = (void*) window->windowGroup();

ditto (c-cast)

> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1144
> +                void** v = (void**) value;
> +                *v = (void*) context;

ditto

> Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:1159
> +        void** v = (void**) value;
> +        *v = (void*) m_private->m_pluginUniquePrefix.c_str();

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.