[Webkit-unassigned] [Bug 72692] [CMAKE] Add the configuration of cmake to select between JSC and V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72692





--- Comment #25 from jaehoon jeong <jh4u.jeong at samsung.com>  2011-11-29 00:40:02 PST ---
(From update of attachment 116490)
View in context: https://bugs.webkit.org/attachment.cgi?id=116490&action=review

>> Source/CMakeLists.txt:8
>> +ADD_SUBDIRECTORY(JavaScriptCore/wtf)
> 
> It makes sense to build wtf first.

I'll make WTF first.

>> Source/CMakeLists.txt:23
>> +    WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WTF_LIBRARY_NAME})
> 
> WTF needs the extra compiler flags regardless of the engine chosen.

I'll make the WTF extra compiler flags to default option regardless of the engine.

>> Source/WebCore/CMakeLists.txt:2441
>>  TARGET_LINK_LIBRARIES(${WebCore_LIBRARY_NAME} ${WebCore_LIBRARIES})
> 
> My point with this in a previous review is: WebCore_LIBRARIES is set to WTF_LIBRARY_NAME when V8 is chosen, and JavaScriptCore_LIBRARY_NAME when JSC is chosen. This means that TARGET_LINK_LIBRARIES() will create a dependency between WebCore_LIBRARY_NAME and WebCore_LIBRARIES, which makes the ADD_DEPENDENCIES() calls redundant. What errors do you get when you remove the ADD_DEPENDENCIES() block?

OK... I understand what you mean. thanks
I remove ADD_DEPENDENCIES of WTF and JavaScirptCore

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.