[Webkit-unassigned] [Bug 72692] [CMAKE] Add the configuration of cmake to select between JSC and V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72692





--- Comment #24 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-11-24 05:11:39 PST ---
(From update of attachment 116490)
View in context: https://bugs.webkit.org/attachment.cgi?id=116490&action=review

It'd be good if you could submit the same patch (without flagging cq? or r?) setting V8 as the default engine and then manually submit it for EWS analysis, just so that we can check if the V8 code path builds fine.

> Source/CMakeLists.txt:8
> +IF (WTF_USE_JSC)
> +    ADD_SUBDIRECTORY(JavaScriptCore)
> +ENDIF ()
> +
> +ADD_SUBDIRECTORY(JavaScriptCore/wtf)

It makes sense to build wtf first.

> Source/CMakeLists.txt:23
> +IF (WTF_USE_V8)
> +    WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WTF_LIBRARY_NAME})

WTF needs the extra compiler flags regardless of the engine chosen.

> Source/WebCore/CMakeLists.txt:2441
> -ADD_DEPENDENCIES(${WebCore_LIBRARY_NAME} ${JavaScriptCore_LIBRARY_NAME})
> +IF (WTF_USE_V8)
> +    ADD_DEPENDENCIES(${WebCore_LIBRARY_NAME} ${WTF_LIBRARY_NAME})
> +ELSEIF (WTF_USE_JSC)
> +    ADD_DEPENDENCIES(${WebCore_LIBRARY_NAME} ${JavaScriptCore_LIBRARY_NAME})
> +ENDIF()
>  TARGET_LINK_LIBRARIES(${WebCore_LIBRARY_NAME} ${WebCore_LIBRARIES})

My point with this in a previous review is: WebCore_LIBRARIES is set to WTF_LIBRARY_NAME when V8 is chosen, and JavaScriptCore_LIBRARY_NAME when JSC is chosen. This means that TARGET_LINK_LIBRARIES() will create a dependency between WebCore_LIBRARY_NAME and WebCore_LIBRARIES, which makes the ADD_DEPENDENCIES() calls redundant. What errors do you get when you remove the ADD_DEPENDENCIES() block?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.