[Webkit-unassigned] [Bug 73015] [EFL] Add alpha channel API to single and tiled backing store.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 25 05:00:37 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73015





--- Comment #8 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-11-25 05:00:36 PST ---
(From update of attachment 116347)
View in context: https://bugs.webkit.org/attachment.cgi?id=116347&action=review

At first glance, this looks like a change for change's sake. I agree that currently the other parameters of bg_color_set are not being used, however we don't know what child implementations might want to do, so I think it is better to err on the safe side and provide more parameters, not less, here. If you provide a function to set alpha, it doesn't really hurt to pass r, g and b with it.

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:211
> +    evas_object_image_alpha_set(item->tile->image, priv->view.tile.hasAlpha);

Was there any problem you noticed with this not being set before?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list