[Webkit-unassigned] [Bug 73015] [EFL] Add alpha channel API to single and tiled backing store.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73015





--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-11-24 23:58:53 PST ---
(From update of attachment 116347)
View in context: https://bugs.webkit.org/attachment.cgi?id=116347&action=review

>>> Source/WebKit/efl/ewk/ewk_tiled_backing_store.h:103
>>> +void ewk_tiled_backing_store_alpha_set(Evas_Object* o, Eina_Bool has_alpha);
>> 
>> In EFL style, it looks they don't use prefix for Eina_Bool type as below,
>> 
>> ewk_view_setting_auto_load_images_set(Evas_Object *o, Eina_Bool automatic);
>> ewk_view_zoom_weak_smooth_scale_set(Evas_Object *o, Eina_Bool smooth_scale);
>> ewk_view_text_matches_highlight_set(Evas_Object *o, Eina_Bool highlight);
>> 
>> So, it seems it is better to use "Eina_Bool alpha" instead of "Eina_Bool has_alpha"
> 
> IMO, Jungjik might refer the evas_object api.
> evas_object_image_alpha_set (Evas_Object *obj, Eina_Bool has_alpha);
> 
> As a result, I agree with api name Jungjik proposed. :)

Ok, Looks good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.