[Webkit-unassigned] [Bug 72946] [GTK] Add WebKitNetworkResponse to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72946


Dan Winship <danw at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danw at gnome.org




--- Comment #5 from Dan Winship <danw at gnome.org>  2011-11-24 07:37:47 PST ---
(In reply to comment #4)
> > We need to look into how we can properly link to soup documentation so this doesn't produce errors during the gktdoc-fixxref run.

I think if you have the libsoup gtk-docs installed in the prefix you are installing webkit into, it will find them automatically.

> > > +guint64 webkit_network_response_get_content_length(WebKitNetworkResponse* response)
> > 
> > Any reason this isn't a property? It is appropriate to use gsize here instead of guint64? Soup seems to use goffset, which I assume is the same data type as gsize.

(Not always. gsize is size_t and goffset is offset_t. On x86_64 they're both 64-bit but on x86 size_t is 32-bit.)

> > Ah, is this why you've chosen to use a property for uri, but not the others? I guess I would prefer that all private data be properties or none of them.
> 
> Yes, because it's construct only.

Having properties for everything is more language-bindings-friendly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.