[Webkit-unassigned] [Bug 72946] [GTK] Add WebKitNetworkResponse to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72946





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-11-23 07:58:14 PST ---
(In reply to comment #3)
> (From update of attachment 116213 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=116213&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitNetworkResponse.cpp:130
> > + * the server. It will normally be a #SoupKnownStatusCode, eg,
> > + * %SOUP_STATUS_OK, though of course it might actually be an unknown
> > + * status code.
> 
> I would rephrase this slightly to: It will normally be a #SoupKnownStatusCode, for example %SOUP_STATUS_OK, though the server can respond with any unsigned integer. 

I copied it literally from the libsoup api docs :-P

> We need to look into how we can properly link to soup documentation so this doesn't produce errors during the gktdoc-fixxref run.

Right.

> > Source/WebKit2/UIProcess/API/gtk/WebKitNetworkResponse.cpp:153
> > +guint64 webkit_network_response_get_content_length(WebKitNetworkResponse* response)
> 
> Any reason this isn't a property? It is appropriate to use gsize here instead of guint64? Soup seems to use goffset, which I assume is the same data type as gsize.

Because data length used by WebKit2 internal API is uint64_t

> > Source/WebKit2/UIProcess/API/gtk/WebKitNetworkResponse.cpp:170
> > +    WebKitNetworkResponse* response = WEBKIT_NETWORK_RESPONSE(g_object_new(WEBKIT_TYPE_NETWORK_RESPONSE, "uri", uri.get(), NULL));
> 
> Ah, is this why you've chosen to use a property for uri, but not the others? I guess I would prefer that all private data be properties or none of them.

Yes, because it's construct only.

> > Source/WebKit2/UIProcess/API/gtk/WebKitNetworkResponse.cpp:176
> > +SoupMessage*
> > +webkitNetworkResponseGetSoupMessage(WebKitNetworkResponse* response)
> 
> Extra newline here. :)

Ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.