[Webkit-unassigned] [Bug 72947] [Qt] Don't pass -graphicssystem to QtTestBrowser if using Qt5

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72947





--- Comment #3 from Csaba Osztrogonac <ossy at webkit.org>  2011-11-24 07:16:35 PST ---
(From update of attachment 116503)
View in context: https://bugs.webkit.org/attachment.cgi?id=116503&action=review

>> Tools/Scripts/old-run-webkit-tests:242
>> +        $platform = "qt-5.0";
> 
> This seems unrelated?

No, we need this change too, because qt-5.0 platform wasn't supported by ORWT before.

>> Tools/Scripts/old-run-webkit-tests:1222
>> +  if(!(getQtVersion() ge "5.0")) {
> 
> Shouldn't that properly check the major version of Qt only? (if major-version < 4)

Of course we can check only the major version, but getQtVersion() (webkitdirs.pm)
parses qmake's output and return major&minor version in this format as string.

I think, that if ((getQtVersion() lt "5.0")) would be good, because 
it is equivalent to (non-existent-yet) (getQtMajorVersion() < 5).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.