[Webkit-unassigned] [Bug 72947] [Qt] Don't pass -graphicssystem to QtTestBrowser if using Qt5

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72947


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116503|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2011-11-24 06:52:25 PST ---
(From update of attachment 116503)
View in context: https://bugs.webkit.org/attachment.cgi?id=116503&action=review

I think the idea is good. The ChangeLog entry is missing and I have a few nitpicks :)

> Tools/Scripts/old-run-webkit-tests:242
> +    } elsif (getQtVersion() eq "5.0") {
> +        $platform = "qt-5.0";

This seems unrelated?

> Tools/Scripts/old-run-webkit-tests:1222
> +  if(!(getQtVersion() ge "5.0")) {

Shouldn't that properly check the major version of Qt only? (if major-version < 4)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.