[Webkit-unassigned] [Bug 73036] Add simple implementation for web intents chromium API data classes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73036





--- Comment #4 from Greg Billock <gbillock at google.com>  2011-11-23 13:17:18 PST ---
(From update of attachment 116388)
View in context: https://bugs.webkit.org/attachment.cgi?id=116388&action=review

>> Source/WebKit/chromium/public/WebIntent.h:44
>> +    WebIntent(const WebString& action, const WebString& type, const WebString& data, int identifier);
> 
> public, non-inline methods need to be annotated with WEBKIT_EXPORT or else you will break the shared library build.
> 
> also, please note that we normally do not export constructors.  instead, we write initialize() methods, and export
> those.  the constructor can call the initialize() method.
> 
> in this case, though... I wonder... will there be no WebCore::Intent class?  if there is such a class, maybe you
> want the constructor to take that instead?
> 
> the same issue applies to WebIntentServiceInfo.

Right. I didn't export the constructor for that reason. Will this break the shared lib?

There will be a WebCore::Intent class; I have that constructor in a separate CL which I'm going to send along soon. For now I just wanted some simple method implementations so I can check in the adjustments to our Chromium code that will use these accessors. I could take the constructors out completely. Shall I just do that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.