[Webkit-unassigned] [Bug 73036] Add simple implementation for web intents chromium API data classes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73036


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116388|review?                     |review-
               Flag|                            |




--- Comment #3 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-11-23 12:14:20 PST ---
(From update of attachment 116388)
View in context: https://bugs.webkit.org/attachment.cgi?id=116388&action=review

> Source/WebKit/chromium/public/WebIntent.h:44
> +    WebIntent(const WebString& action, const WebString& type, const WebString& data, int identifier);

public, non-inline methods need to be annotated with WEBKIT_EXPORT or else you will break the shared library build.

also, please note that we normally do not export constructors.  instead, we write initialize() methods, and export
those.  the constructor can call the initialize() method.

in this case, though... I wonder... will there be no WebCore::Intent class?  if there is such a class, maybe you
want the constructor to take that instead?

the same issue applies to WebIntentServiceInfo.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.