[Webkit-unassigned] [Bug 72692] [CMAKE] Add the configuration of cmake to select between JSC and V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72692





--- Comment #11 from jaehoon jeong <jh4u.jeong at samsung.com>  2011-11-22 20:01:26 PST ---
(From update of attachment 116055)
View in context: https://bugs.webkit.org/attachment.cgi?id=116055&action=review

>> Source/WebCore/CMakeLists.txt:871
>> +    html/shadow/DetailsMarkerControl.cpp    
> 
> Unneeded change.

There are some spaces at the end of it.. I made a mistake,, :(

>> Source/WebCore/CMakeLists.txt:2429
>> +ENDIF()
> 
> I think this section is not needed -- TARGET_LINK_LIBRARIES will automatically create the dependencies between the targets.

If only JavaScriptCore_LIBRARY_NAME is setted as TARGET_LINK_LIBRARIES when build with v8.
Undefined reference errors occurr related with WTF libraries. so I think that this change need to be included.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.