[Webkit-unassigned] [Bug 72692] [CMAKE] Add the configuration of cmake to select between JSC and V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72692





--- Comment #10 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-11-21 04:55:55 PST ---
(From update of attachment 116055)
View in context: https://bugs.webkit.org/attachment.cgi?id=116055&action=review

> Source/WebCore/CMakeLists.txt:871
> -    html/shadow/DetailsMarkerControl.cpp
> +    html/shadow/DetailsMarkerControl.cpp    

Unneeded change.

> Source/WebCore/CMakeLists.txt:2429
> -ADD_DEPENDENCIES(${WebCore_LIBRARY_NAME} ${JavaScriptCore_LIBRARY_NAME})
> +IF (WTF_USE_V8)
> +    ADD_DEPENDENCIES(${WebCore_LIBRARY_NAME} ${WTF_LIBRARY_NAME})
> +ELSEIF (WTF_USE_JSC)
> +    ADD_DEPENDENCIES(${WebCore_LIBRARY_NAME} ${JavaScriptCore_LIBRARY_NAME})
> +ENDIF()

I think this section is not needed -- TARGET_LINK_LIBRARIES will automatically create the dependencies between the targets.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.